Hi Vincent, hi all, I'm not 100% sure if the plugin should apply the "unit scaling" (or not). Actually we worked on that subject and thought it was not the role of the reader to scale the model into meters. Our reflexion was "and what if the user wants nanometers, or inches, or kilometers, or light-years? This may even lead to precision problems.". So we used the plugin data (See ReaderWriterDAE.cpp around line 91 : "DAE-AssetUnitMeter") to scale the model only if the user wants. But your implementation doesn't seem wrong, so I suggest you simply encapsulate your change in an opion-driven "if(...)". What do you think about this? Actually the same question may be asked for "Z up" parameter, and for writing. Don't you think all of this should be unified? What I suggest is: - A read option to apply "up axis" information (default = true?) - A read option to apply "unit scaling" information (default = true?) - A write option to tell which axis is Up (= we may change a bit the "daeZUpAxis". default=???) - A write option to tell the unit used in the model (default=meter I guess, as this the "SI" international standard)
Thoughts? Ideas about default values? Cheers, Sukender PVLE - Lightweight cross-platform game engine - http://pvle.sourceforge.net/ ----- "Vincent" <[email protected]> a écrit : > Hi, > > The asset scale was not getting applied into the postion transform if > it was not 1.0. This takes care of that issue. > > Cheers, > Vincent > > ------------------ > Read this topic online here: > http://forum.openscenegraph.org/viewtopic.php?p=35665#35665 > > > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
