Hi Piotr and Jeremy, Thanks for the fix Piotr, and thanks to Jeremy for doing the review. Changes now merged and submitted to svn/trunk.
Cheers, Robert. On Wed, Feb 9, 2011 at 5:45 PM, Piotr Gwiazdowski <[email protected]> wrote: > Hi Robert, > > Recently I've been having some trouble with osgWidget::StyleManager > (I'll omit osgWidget namespace from now on). It seems to me that there > are some inconsistency in the code. In Style there are multiple > applyStyle method overloads, applying style for different > widgets/windows built-in in osgWidget. Plus you can do overrides. It's > good so far. > > The problem lies in StyleManager::_applyStyleToObject (which calls > _coearceAndApply, which calls _applySpecificStyle, which calls > Style::applyStyle). With current implementation Style::applyStyle > variants for Input, Window, Frame::Corner, Frame::Border, > Window::EmbeddedWindow are never called, because their classes' names > are omitted in methods' if/else if block, making it impossible to use > styles with most than half of built-in widget/window types. > > My fix simply adds couple else if blocks, making each > Style::applyStyle variant callable. By the way, I think that next > update should add Style::applyStyle overload for Table class and add > proper className overloads for Input and Window. > > -- > Best regards, > Piotr Gwiazdowski > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
