Hi Torben, On Mon, Mar 14, 2011 at 10:14 AM, Torben Dannhauer <[email protected]> wrote: > Hi Robert, > > I'm using Microsoft Visual Studio 2008 Standard (Service Pack1). > I havn't tested it, but I strongly assume that all versions of VS 2005 and > VS2008 are affected. I can't say anything about VS2010 because I never used > it. > > You are right, it is not a good behavior of VS, but it's code analyser seems > not to be very clever. > > What are your suggestions?
In this case I just merged the warning fix, but with bogus warnings like this we just need to way up the risks/benefits very carefully. All code changes have the potential for introducing bugs or adding to overall code complexity making it less managable. The more false positives you have to squash the higher the risk of the nergative impact, so at some point you might need to decide that squashing the warning via compiler level directives will be safer and more productive. For this bug in the compiler and in this instance I've gone for merging the "fix". We just need to monitor the issue, if it keeps coming up then we'll need to squash the warning report. Robert. _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
