Thanks Robert - that looks good and is easier to read. Ryan
On Fri, May 27, 2011 at 6:26 AM, Robert Osfield <[email protected]>wrote: > Hi Ryan, > > Submission looks fine, now merged and submitted to svn/trunk. The > only small tweak I did was to move the lines > > if( _trans_set == false && _use_world_frame == false) > T = Matrix::translate( bs.center() ); > > Into the preceeding block so that we could remove the extra > _use_world_frame check, this improves the flow of the code a little: > > if (_use_world_frame) > { > C.makeIdentity(); > } > else > { > C = Matrix::translate( -bs.center() ); > > if (_trans_set == false) > T = Matrix::translate( bs.center() ); > } > > I presume this is fine. > > Cheers, > Robert. > > On Wed, May 25, 2011 at 10:38 PM, Ryan Pavlik <[email protected]> wrote: > > All, > > I've attached zipped modified full files for trunk and the 2.8 branch of > the > > promised improvement to the osgconv tool. > > Existing osgconv behavior is to transform the model bounding sphere > center > > to the world origin before performing transformations specified on the > > command line, and translating back after rotation and scaling unless an > > alternate translation is specified. This patch adds a setting to the > > OrientationConverter class in osgconv to disable this extra > transformation, > > which has the effect of applying specified transforms with respect to the > > input world coordinate system, rather than to the center of the bounding > > sphere. It also adds a command line argument "--use-world-frame" to > enable > > this behavior. When this command line argument is not passed, behavior is > > unchanged from before the patch. The usage text has been updated to > reflect > > this additional option, and the comments in OrientationConverter are also > > updated. > > > > Thanks! > > Ryan > > -- > > Ryan Pavlik > > HCI Graduate Student > > Virtual Reality Applications Center > > Iowa State University > > > > [email protected] > > http://academic.cleardefinition.com > > > > _______________________________________________ > > osg-submissions mailing list > > [email protected] > > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > > > > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > -- Ryan Pavlik HCI Graduate Student Virtual Reality Applications Center Iowa State University [email protected] http://academic.cleardefinition.com
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
