Hi Robert,While testing OSG 3.0 I also recompiled VPB trunk against it, and came across a few compile warnings from gcc that was easy to fix / remove.
The attached tgz file contains fixes for the following warnings:* trunk/include/vpb/BuildLog:190: warning: ‘class vpb::Logger’ has virtual functions but non-virtual destructor * trunk/include/vpb/Destination:72: warning: ‘class vpb::DestinationVisitor’ has virtual functions but non-virtual destructor * trunk/src/vpb/PropertyFile.cpp:321: warning: ‘file.vpb::FileProxy::_requiresSync’ may be used uninitialized in this function * trunk/src/vpb/TaskManager.cpp:105: warning: converting to ‘int’ from ‘double’ * trunk/src/vpb/TaskManager.cpp:174: warning: converting to ‘int’ from ‘double’
When patch is applied VPB compiles without warnings.
Best regards,
John
% svn diff
Index: include/vpb/Destination
===================================================================
--- include/vpb/Destination (revision 1037)
+++ include/vpb/Destination (working copy)
@@ -71,6 +71,8 @@
class DestinationVisitor
{
public:
+ DestinationVisitor() {}
+ virtual ~DestinationVisitor() {}
virtual void traverse(CompositeDestination&);
virtual void apply(CompositeDestination& cd);
Index: include/vpb/BuildLog
===================================================================
--- include/vpb/BuildLog (revision 1037)
+++ include/vpb/BuildLog (working copy)
@@ -189,6 +189,8 @@
class Logger
{
public:
+ Logger() {}
+ virtual ~Logger() {} // Virtual destructor needed to avoid gcc
warning
virtual void setBuildLog(BuildLog* bl) { _buildLog = bl; }
BuildLog* getBuildLog() { return _buildLog.get(); }
Index: src/vpb/PropertyFile.cpp
===================================================================
--- src/vpb/PropertyFile.cpp (revision 1037)
+++ src/vpb/PropertyFile.cpp (working copy)
@@ -30,7 +30,8 @@
typedef unsigned int offset_t;
FileProxy(const std::string& filename):
- _fileID(0)
+ _fileID(0),
+ _requiresSync(false)
{
if (vpb::access(filename.c_str(), F_OK)==0)
{
Index: src/vpb/TaskManager.cpp
===================================================================
--- src/vpb/TaskManager.cpp (revision 1037)
+++ src/vpb/TaskManager.cpp (working copy)
@@ -102,7 +102,7 @@
int revisionNum = -1;
if (isNumeric)
{
- revisionNum = atof(extension.c_str());
+ revisionNum = atoi(extension.c_str());
filename = osgDB::getNameLessExtension(filename);
extension = osgDB::getFileExtension(filename);
basename = filename;
@@ -171,7 +171,7 @@
int revisionNum = -1;
if (isNumeric)
{
- revisionNum = atof(revisionExtension.c_str());
+ revisionNum = atoi(revisionExtension.c_str());
sourceMap[revisionNum] = file;
}
else
turin(trunk)%
--
This email was Anti Virus checked by Astaro Security Gateway.
http://www.astaro.com
vpb_svn1037_gcc_warning_fix.tgz
Description: GNU Zip compressed data
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
