Hi Jason, The first fix I'm pretty comfortable with - this is defiiately a bug. I'm still trying to work if the second fix actual addresses a bug, or just fixes things for a particular user with a particular usage model, which may or may not be entirely appropriate. To know for sure that the second fix makes sense in all contexts I'll need to look specifically what is going wrong in your case. Could you provide an example that illustrates the problem?
Thanks, Robert. On Wed, Jul 27, 2011 at 1:33 AM, Jason Beverage <[email protected]> wrote: > Hi Robert, > > My previous patch fixed an obvious error, this one I believe is a bit > more complete. I was running into an issue where I was setting up a > graphicsWindowEmbedded and then settings it's Viewport to something > other than the default. The code path for when there is no graphics > window in getCameraContainingPosition doesn't take the Viewport's > position and size into account even though the event's range is based > on the Viewpor. This patch uses the Viewport if it exists to get the > minX, minY, width and height values and uses the graphics context > traits if it doesn't exist. > > Thanks! > > Jason > > On Tue, Jul 26, 2011 at 7:52 PM, Jason Beverage <[email protected]> > wrote: >> Hi Robert, >> >> Here is a small fix for getCameraContainingPosition. getXMin was >> being used in a case where getYMin should be used instead. >> >> Thanks! >> >> Jason >> > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
