Hi David, On 8 November 2011 18:28, David Fries <[email protected]> wrote: > Of the two ways to use the Tessellator object, only > retessellatePolygons was applying the winding and boundary option. > Moved the gluTessProperty calls into beginTessellation(). > > There's a comment typo fix, removing an unused VertexPointList > typedef, and allocates one _tobj instead of one per tesellation. > Protections were added to check that _tobj was allocated in the few > remaining places it wasn't being checked.
These changes all look good, now merged and submitted to svn/trunk. > --- > On a side note, I would like to avoid the 'new Vec3d' in > Tessellator::addVertex for each call to > gluTessVertex(tess, location, data). > The RedBook leaves it ambiguous if the location pointer must > remain valid after gluTessVertex or not. > http://www.opengl.org/sdk/docs/man/xhtml/gluTessVertex.xml > says that changing location is not safe, so being conservative, I'll > leave it as is, even though the Mesa GLU library copies the data not > the pointer, so it is currently safe. The OSG now integrates the Mesa GLU code directly so we won't need to worry about alternative implementations. Cheers, Robert. _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
