Hi Robert, You're right on both counts, I can make these changes if you like.
However, I've had second thoughts about this submission. The reason I wrote it was because I wanted a simple command line viewer for stereo images. I could have used osgStereoImage out the box if it weren't for the geometric distortion. Given that the geometric distortion is only useful for a very specific use case, I propose that I simply modify the existing example to remove the geometric distortion in favour of a flat quad. This would keep the very handy slideshow functionality already in osgStereoImage and make the example more useful to others. Really this is what I should have done in the first place.. What do you think? Kim. On 7 February 2012 11:53, Robert Osfield <[email protected]> wrote: > Hi Kim, > > I've just done a quick code review of your stereo image app, it > generally looks OK, but a couple of things seem a bit odd. > > First up you reset the eye separation to 0.0, this will only be > required if you don't place the image geometry on the image plane of > the display and won't to force off any normal stereo effect. When I > use stereo imagery with Present3D it's almost always in the context of > other text, 3d models which require normal stereo display, in these > cases to get the stereo imagery/video to work correctly one simply > places the imagery on the image plane and you can still have the rest > of the 3d working perfectly. I wouldn't want to set a president to > the OSG community that you have to switch set the eye separation to > zero when it's not required. > > Secondly I'm surprised that you are defaulting to a non full screen > window. For stereo work one it's generally best to use a full screen > window to avoid any distractions that might diminish the 3D effect so > of all places this is where I'd use a full screen as a default. > > Thoughts? > Robert. > > On 9 November 2011 21:39, Kim Bale <[email protected]> wrote: > > Hi Robert, > > > > I was working with stereo photography a few weeks back and needed a > program > > to view the stereo pairs. I wrote this very quick app to serve the > purpose. > > I realise that there is already a stereo image viewer example but this > is a > > more complete example. It resizes images to fit the screen and doesn't > have > > the geometrical distortion found in the osgStereoImage example. > > > > Given that OSG is used so widely for stereo rendering I thought it might > be > > a useful addition to the OSG source both as an example and a utility. > > > > Let me know what you think, > > > > Regards, > > > > Kim. > > > > _______________________________________________ > > osg-submissions mailing list > > [email protected] > > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
