Thanks Sergey, changes now merged and submitted to svn/trunk.

On 21 February 2012 14:49, Sergey Polischuk <[email protected]> wrote:
> Hello there
>
> In and Out control points were computed incorrectly for some animation 
> channels with cubic bezier interpolation
>
> diff:
>
> --- src/osgPlugins/fbx/fbxRAnimation.cpp        (revision 12996)
> +++ src/osgPlugins/fbx/fbxRAnimation.cpp        (working copy)
> @@ -115,7 +115,7 @@
>
>             osgAnimation::FloatCubicBezier key(
>                 val * scalar,
> -                (val + leftTangent.mDerivative / 3.0) * scalar,
> +                (val - leftTangent.mDerivative / 3.0) * scalar,
>                 (val + rightTangent.mDerivative / 3.0) * scalar);
>
>             curveTimeMap[nCurve][fTime] = key;
> @@ -385,8 +385,8 @@
>                     }
>                     osgAnimation::FloatCubicBezier key(
>                         osg::DegreesToRadians(angle),
> -                        osg::DegreesToRadians(angle + 
> leftTangent.mDerivative / 3.0),
> -                        osg::DegreesToRadians(angle - 
> rightTangent.mDerivative / 3.0));
> +                        osg::DegreesToRadians(angle - 
> leftTangent.mDerivative / 3.0),
> +                        osg::DegreesToRadians(angle + 
> rightTangent.mDerivative / 3.0));
>
>                     
> pKeyFrameCntr->push_back(osgAnimation::FloatCubicBezierKeyframe(
>                         fTime,
>
>
> modified source file from head (rev 12996) attached
>
> _______________________________________________
> osg-submissions mailing list
> [email protected]
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to