Hi Robert, i added support for StencilTwoSided in DataInputStream and DataOutputStream. And by the way, I found bug in StencilTwoSided.h file and fixed it. All 3 files I add to zip file. I hope that's all :)
Thanks, Lukasz robertosfield wrote: > HI Lukasz, > > On 16 March 2012 10:52, Lukasz Izdebski <> wrote: > > > I send new zip file because I made a mistake sorry about that. > > file files2.zip is now proper and contains a 4 files. > > > > Thanks for the zip, files can through with filenames intact. I've > just done a review but can't merge yet as you did supply changes the > DataInputStream and DataOutputStream to support the new > StencilTwoSided implementation you've provided. Did you modify these > and neglect to send me the changes or did you not realize that these > needed modifying? > > I've reviewed the change to LOD.cpp but your change is flawed as the > output of the LOD has the mode output before the center and your code > reads the center then the mode which will result in corruption. I > have fixed the LOD.cpp to read the mode then the center then applied > the changes below. > > Could you have a looking at adding the required support for > StencilTwoSided to DataInputStream and DataOutputStream and once > you've got things work send me along the files. > > Thanks, > Robert. > > > Index: LOD.cpp > =================================================================== > --- LOD.cpp (revision 13032) > +++ LOD.cpp (working copy) > @@ -36,7 +36,7 @@ > out->writeInt(getCenterMode()); > out->writeVec3(getCenter()); > > - out->writeInt(getRangeMode()); > + out->writeInt(getRangeMode()); > > // Write rangelist > int size = getNumRanges(); > @@ -66,12 +66,14 @@ > if ( in->getVersion() > VERSION_0002 ) > setRadius(in->readFloat()); > > - // Read centermode > - setCenterMode((osg::LOD::CenterMode)in->readInt()); > - setCenter(in->readVec3()); > + // Read centermode and center > + osg::LOD::CenterMode centerMode = > (osg::LOD::CenterMode)in->readInt(); > + osg::Vec3 center = in->readVec3(); > + setCenter(center); > + setCenterMode(centerMode); > > - if ( in->getVersion() > VERSION_0002 ) > - setRangeMode((RangeMode)in->readInt()); > + if ( in->getVersion() > VERSION_0002 ) > + setRangeMode((RangeMode)in->readInt()); > > // Read rangelist > int size = in->readInt();; > _______________________________________________ > osg-submissions mailing list > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > ------------------ > Post generated by Mail2Forum ------------------ Read this topic online here: http://forum.openscenegraph.org/viewtopic.php?p=46352#46352 Attachments: http://forum.openscenegraph.org//files/files3_874.zip _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
