Hi Erik,

On 23/03/12 11:37 , Erik den Dekker wrote:
>> Also included is a modified src/osgViewer/CMakeLists.txt that more reliably 
>> detects OS X
>> versions 10.5, 10.6, and 10.7 and uses Cocoa on these platforms.  It also 
>> checks for the
>> new location of the SDK, that was changed with Xcode 4.3.
> 
> I think I just beat you to it, 9 minutes ago :-)... Although I used a slightly
> different approach. Can you please comment on it, so we can work out what 
> would be the best one to
merge?

Yes, I found your submission when the mail folder was refreshed.. funny how 
that happens.

I had a look at your solution and must say it's a lot cleaner than my fall-back 
check for
the different paths.  I've replaced my changes (which had a bug anyway) with 
yours and
they work beautifully.

The only thing I would suggest would be to change the cmake variable name from
APPLE_PLATFORM_SDK_CANONICAL_NAME to something like OSG_OSX_SDK_NAME or 
something, to make
it more discoverable.

Robert, please ignore my patch to the src/osgViewer/CMakeLists.txt file.

Cheers,
/ulrich
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to