Hi David,

On 5/04/12 18:16 , David Callu wrote:
> Patch for this error was already submit by Jordi Torres in
> 
> "Uniform update to OpenGL 420 and Atomic Counter Buffer/Uniform" thread

Drat, missed that.

> Can you confirm it work for you ?

Yes, the change to Uniform.cpp compiles for me.  My patch also contains a patch 
to the
Uniform header file, that is related to this issue.

Jordi's patch is actually very similar to what I originally came up with, but I 
believe
that using the 'base_class' typedef is actually cleaner and more maintainable 
than having
the duplicated template information.

This:
>bool Uniform::getElement( unsigned int index, osg::Matrix2& m2 ) const
>{
>...
>    m2.base_class::set( &((*_floatArray)[j]) );
>...
>}

rather than:
>bool Uniform::getElement( unsigned int index, osg::Matrix2& m2 ) const
>{
>...
>    m2.MatrixTemplate<float, 2, 2>::set( &((*_floatArray)[j]) );
>...
>}

Thoughts?

Cheers,
/ulrich
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to