Hi Robert,
I guess the list of submissions can be hard to keep up with during
summer, but has my ESRIShape submission below been considered yet?
Regards,
Andreas
On 2012-07-01 01:04, Andreas Ekstrand wrote:
Hi,
The attached ESRIShape.cpp contains fixes for comparing calculated
byte sizes with the content length from the record header. According
to the ESRI Shape documentation
(http://www.esri.com/library/whitepapers/pdfs/shapefile.pdf), the
content length is specified in 16 bit words, which is why I have
multiplied it by 2 when comparing to byte sizes. Note that the
comparison in line 813 is made with a fix number of 16-bit words so it
hasn't been changed.
This fixes problems with PolygonZ records where the previous code was
reading past the end of the record since it thought it had M values
even if it didn't. I suspect the problem that James McGlone had back
in 2006 was the same but reversed, when he tried to simply comment out
the check, which was a (correctly) refused submission.
Regards,
Andreas Ekstrand
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
