Hi James,

Thanks for the new plugins, I've merged the plugin and got the warning:

/home/robert/OpenSceneGraph/src/osgPlugins/ktx/ReaderWriterKTX.cpp:22:1:
warning: overflow in implicit constant conversion [-Woverflow]
/home/robert/OpenSceneGraph/src/osgPlugins/ktx/ReaderWriterKTX.cpp:22:1:
warning: overflow in implicit constant conversion [-Woverflow]

So I changed the static variable:
     const char ReaderWriterKTX::FileSignature
To
     const unsigned char ReaderWriterKTX::FileSignature

As this fixes the warning and is consistent with the memcpy to the
uint8_t indentifier variable.

With this fixes changes are now merged and submitted to svn/trunk.

Robert.


On 3 October 2012 22:01, James Athey <[email protected]> wrote:
> I've attached a new osgDB ReaderWriter that can read Khronos Texture Files
> (KTX).  The KTX file format is straightforward and designed to be easy to
> use in OpenGL.
>
> http://www.khronos.org/opengles/sdk/tools/KTX/file_format_spec/
> http://www.khronos.org/opengles/sdk/tools/KTX/
>
> The attached plugin can read:
>
> * 1D, 2D, and 3D textures
> * uncompressed and compressed images
> * mipmapped and non-mipmapped textures
> * little-endian and big-endian files
> * textures from files as well as seekable istream objects
>
> It does not handle:
>
> * array textures (not supported by the ReaderWriter API)
> * cubemap textures (not supported by the ReaderWriter API)
> * the "KTXorientation" key-value pair; support could be added later (see
> the file format spec for more information)
> * non-seekable istream objects (would require more complicated memory
> management)
>
> The supplied sources compile and work as of r13155.  Not included is the
> change to src/osgPlugins/CMakeLists.txt; all that's needed is a
> "ADD_SUBDIRECTORY(ktx)" in the appropriate place.
>
> James Athey
> APX Labs
>
>
> _______________________________________________
> osg-submissions mailing list
> [email protected]
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to