Hi Kristofer,
I've just merged your Qt5 changes with a view to testing their
build/execution and to generally review the changes, this has mostly
gone smoothly only requiring a few tweaks to get things build, and now
have Qt4/OSG version built. There are a couple of things that need
clarifying/improving, hopefully we can sort these out. The first
issue is that I get the cmake warning :
CMake Warning at CMakeLists.txt:546 (FIND_PACKAGE):
By not providing "FindQt5Widgets.cmake" in CMAKE_MODULE_PATH this project
has asked CMake to find a package configuration file provided by
"Qt5Widgets", but CMake did not find one.
Could not find a package configuration file provided by "Qt5Widgets" with
any of the following names:
Qt5WidgetsConfig.cmake
qt5widgets-config.cmake
Add the installation prefix of "Qt5Widgets" to CMAKE_PREFIX_PATH or set
"Qt5Widgets_DIR" to a directory containing one of the above files. If
"Qt5Widgets" provides a separate development package or SDK, be sure it has
been installed.
The cause is kinda obvious - no appropriate Qt5 find package on my
system. Are these cmake files part of your cmake install? Which
version of cmake do you have? I suspect others won't have the scripts
as well so might get concerned that something serious is wrong based
on these warnings. Given that Qt support in the OSG is an optional
build component having warnings about them can be misleading - users
can think there is a problem when there isn't one at all.
Might there be a cmake check we can add to avoid trying to include Qt5
when cmake doesn't have the required find scripts?
Another thing area I'd like to clear up is the way that the Qt4 and
Qt5 blocks within CmakeLists.txt files are not adjacent - you've put
the Qt5 ones after everything else. I would have thought one would
keep the Qt4 and Qt5 parts of the cmake files side by side so it's
obvious they are mutually exclusive. Is there a reason to the Qt5
last? Could you we it back to come before/after the Qt4 blocks?
Thanks for you assistance,
Robert.
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
