Hi Aurelien, Thanks for the updates source code. I've just done a review and am I little curious about whether perhaps it's time to push the normalize bool from Geometry::ArrayData::normalize into osg::Array itself. I suggest this as I've got a submission from David Callu that proposes to support the integer and double versions of the OpenGL vertex pointer calls - I haven't merged this submission yet, but again I had the feeling that perhaps this proporty should be associated with the array data storage rather than external to it.
I haven't thought deeply about the issues yet, but my gut instinct is that perhaps we should have a bool Array::s/getNormalize() and bool Array::s/getMaintainDataType(). Such a change would have quite wide changes to the serializers and bits of the API so it's not a lightweight option, but it just feels more contained and right to me. Going this approach would avoid the need for passing extra parameters for normalizing and selecting integer/double versions of vertex pointers around. It should avoid the need for duplicating some of the array dispatchers as well. If putting this variables into the osg::Array is the right thing to do then I'll tackle these API changes and get things working, then we can then start extending the functionality. Thoughts? Robert. On 1 June 2013 15:00, Aurelien Albert <[email protected]> wrote: > Hi, > > Here is the submission updated with current svn trunk. > > The code stay the same, but I've removed to optionnal debug output so the > code is easier to read. > > Thank you! > > Cheers, > Aurelien > > ------------------ > Read this topic online here: > http://forum.openscenegraph.org/viewtopic.php?p=54366#54366 > > > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
