Hi Martin, On 4 June 2013 08:13, Martin Naylor <[email protected]> wrote: > Hi Robert, > Please find attached changes for removal of inheriting fstream and changes > in osg plugin to suit. > I hope I got it right!
Thanks changes look modest and appropriate, now merged and submitted to svn/trunk :-) > I wonder if its also better to rename the function to something like openUTF > may be more appropriate and not sure if its best to move the function to > fileutilities in osgdb? > There is also the ifstream and ofstream, but I dont receive the c4250 > warning on these? I feel the subclassing from ifstream and ofstream isn't ideal, but it does hide the need to provide a filename conversion directly on the constructor and open that we'd need to do otherwise, so while a bit ugly it does make UT8 filename a bit easier to roll out to wider number of plugins. The alternative is to go through all instances of where ofstream and ifstream are used and explictly call a function to have the UT8 filename. Perhaps another approach would be to have a osgDB::filename class (maybe a sublass from std::string) that has a custom c_str() method that does the UT8 expansion when needed. Thoughts? Robert. _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
