Hi Nathan, I have just done an initial review of your changes, but am not an expert in dae nor one of the authors of this plugin, so not personally in a strong position to judge the relative merits of the changes. Changing the default behaviour does concern me as it could have unintended consequences for those whos code relies upon the current configuration. It could be that others are having exactly the same problem as you but haven't attempted to get to the bottom of it.
As I don't have the knowledge to make a judgement call personally I think it would be really useful to make a wider call for review of your changes. I'd hope to get a consensus on what is best to do here. I could just forward your email to osg-users mailing list/forum and make a call for comments, or I could let you introduce the issues and the solution you went for. What way do you want to progress? Cheers, Robert. On 28 March 2013 18:41, Nathan Jones <[email protected]> wrote: > We ran into an issue with using OSG to convert between file formats. > daeReader knows about and understands "usePredefinedTextureUnits" and > "useSequencedTextureUnits" but other writers did not (e.g. 3DS and > VRML look at texture unit 0). Furthermore, it looks (by examination > and experimentation) that the use of > daeReader::Options::usePredefinedTextureUnits in daeReader.cpp was > inconsistent. There were some instances where the MAIN_TEXTURE unit > expecting the sequenced unit to be at position 0 and some expected it > to be at position 1. Since the other exporters expect it to be at > position 0, I made it always read/write at position 0 if the user > specifies useSequencedTextureUnits. > > I tested using several collada files from different vendors (Google, > BAE, etc.) and tested observable behaviors using osgviewer and > osgconv. > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
