Hi Sebastian,
Thanks for doing this, much appreciated. I have merged all the place
where you've replaced a Geometry::set*Binding(), but haven't yet
merged the changes to avoid using Geometry::get*Binding() - my logic
is simply that the former require less code, while the later all
required more code. The issue with replacing get*Binding() requiring
more code is something I'd avoid, I'm not yet sure of the best
solution going forward but it's one I'll ponder on, happy to take
suggestions.
One solution might be to retain the get*Binding() method but return an
osg::Array::Binding, Or perhaps have a helper method
osg::getBinding(osg::Array*) that simply implemented like:
inline osg::Array::Binding getBinding(osg::Array* array)
{
return array ? array->getBinding() : osg::Array::BIND_OFF;
}
For OSG-3.2 I don't plan on removing the Geometry::get*Binding()
methods so this isn't a critical issue, so happy to take things at a
more relaxed pace w.r.t resolving all these little issues.
Robert.
On 26 June 2013 12:04, Sebastian Messerschmidt
<[email protected]> wrote:
> Hi Robert,
>
> I've taken some time and refactored some places where the old set*Binding
> were used.
> The changes are against 3.1.8 and I've tested various models and some of the
> examples.
>
> I hope the changes are as minimal as possible to reflect the new Geometry
> interfaces
>
> _______________________________________________
> osg-submissions mailing list
> [email protected]
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
