Thanks Laurens, fix merged and submitted to svn/trunk.
On 28 June 2013 14:16, Laurens Voerman <[email protected]> wrote: > Hi Robert, > the current version of BufferObject causes a huge amount of warnings in > Visual Studio 2012 like: > > OpenSceneGraph/include\osg/BufferObject(701): warning C4138: '*/' found > outside of comment (E:\osg\osgSvn\OpenSceneGraph\src\osg\Array.cpp) > > adding a space before /* fixes the problem > void removeClient(osg::Object * /*client*/) { --_numClients; } > > full file attached (OpenSceneGraph/include/osg/BufferObject - zipped). > > Regards, Laurens. > > > On 6/28/2013 2:16 PM, Robert Osfield wrote: >> >> Hi David, >> >> I did a merge against all the different comments together and mostly >> everything looks reasonable and I've gone ahead and merged. There a >> couple areas I've haven't merged. >> >> I got part way through the serializers and file after file exactly the >> same usage of OSG_UNUSED was cropping up. I strongly dislike the idea >> of code for just for the sake of quashing inappropriate warning, >> adding such code is a risk in itself and makes the code less readable, >> it's just plain crazy. I understand in some places it's hard to get >> around such warnings where there is a #if .. >> code_block_that_uses_variable #else >> code_block_that_doesnt_use_variable #endif, using the OSG_UNUSED >> approach is perhaps justifiable in these cases but even then it's >> hack. When hacks have to occur they need to be used sparingly and for >> a very specific purposes and clearly understandable to the reader. >> The changes to serializers don't fit with using sparingly and they are >> way too obscure to understand what they are doing their - the variable >> that it's associated with it hidden by the rest of the macros. >> >> The way to address the warnings in the serializers has to be tackled >> either with changes to the core macros being used or disabling the >> problem warning for the serializers. >> >> The other part I didn't merge was the the src/osg/glu code, the >> problem here was that your editor/tool for fixing the warnings changes >> the indentation resulting in less readable code. Warning fixes can't >> come at the cost of lower readability so I've not merged them. In >> this case we either change the indentation in the glu code so that the >> tools used don't mess things up - I presume it's an issue of tabs not >> being handled appropriately. >> >> The rest of the changes and now checked into svn/trunk. >> >> Cheers, >> Robert. >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
