Hi Jan, On 1 July 2013 10:35, Jan Ciger <[email protected]> wrote: > If you want to quieten those warnings about unused > variables/parameters, GCC has these flags: > > -Wno-unused-function > -Wno-unused-label > -Wno-unused-value > -Wno-unused-variable > > Using those is better than polluting the code with hacks to silence > the warnings. > On the other hand, some of those could be potential bugs (declared but > unused variable/argument is either a mistake or perhaps a design > error?), so hiding the warnings can be counter-productive if it is on > by default.
Which warnings cause more problems than they worth is very much a case by case issue, blanket warning suppression is bad, local warning supression is better. For instance not having users suppress warnings when compiling against the OSG is ideal, so the are headers need to be pretty clean, but warnings in our .cpp's that we know are unhelpful would be more appropriate for suppression. > Perhaps for the release/stable version we could add the above flags > using a CMake option if needed, but it shouldn't be default. We have controls in Cmake for controlling the aggressive warnings. I don't personally get many warnings when building the OSG in it's default state (which as OSG_USE_AGGRESSIVE_WARNINGS ON). I have g++ 4.7.3 installed on my system, any that do appear I fix pretty quickly. The only real problem area I'd like to see fixed in the ffmpeg deprecated warnings, this needs code changes to update deprecated code usage, but I'm no ffmpeg expert so would struggle to do this without spending time learning about the latest ffmpeg rev. Robert. _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
