Hi Robert, Quoting "Robert Osfield" <[email protected]>:
Oh forgot to mention, I've checked in my fix to mipmap.c and am currently doing a debug build to make sure the OSG compiles fine.
Odd; the 'assert' is in a #ifdef GLES1/2_AVAILABLE, maybe that's different on OS X?
I feel the appropriate thing to do with this code is to remove the assert and remove the target parameter completely. The function in question is only ever called from the gluBuild3DMipmaps function which really should only be called from 3D textures. Personally I'm not in favour of assert, much preferring checks for validity to be done at compile where possible, of invalid values might occur at runtime that one always checks for them so am happy to recode to avoid use of assert, or simply removing them or replace them with something that isn't just done on a debug build.
I'm with you on this - if the parameter isn't needed at all and it doesn't break the public API then the best solution is to remove it completely.
If you want I can change this tonight. Cheers, /ulrich _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
