Hi Torben, I haven't done a review yet but a refactor sounds like a big change so close to a release, while it won't change the ABI it opens the door for build and runtime issues that will need resolving.
The RestHTTP plugin is very specialist plugin that has only used under one iOS/OSX project as far as I'm aware of so not rolling it out on all platforms right away won't be an issue for OSG-3.2. Would it be OK just to disable build under Windows for OSG-3.2 and then look to resolve this issue in svn/trunk once OSG-3.2 is out? Robert. On 23 July 2013 14:44, Torben Dannhauer <[email protected]> wrote: > Robert, > > Please find attached my changes to the restHTTP Plugin. > > I was not able to built OSG with the old restHttp Plugin, even with support > by the developer. It was based on the standalone ASIO library, I failed > trying it with ASIO standalone and ASIO boost. > > Therefore I decided to refactor the project. > > It was (And is) based on Boost ASIO example "server2". > I did not "anonymize" the code to make tracking of boost changes easier. > It now uses CMakes default "FindeBoost" cmake module instead of the > previous > (bit hacky) selfmade solution. > > After that, OSG should compile fine with MSVC2012 (and the 3rdParty plugin) > > Thanks, > Torben > > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > >
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
