Thanks Sebastian, fix merged and submitted to svn/trunk and OSG-3.2 branch.

On 1 August 2013 09:07, Sebastian Messerschmidt
<[email protected]> wrote:
> Hi Robert,
>
> here is the complete file and the tester2.flt + image of the expected
> result:
>
> cheers
> Sebastian
>
>
>> Hi Sebastien,
>>
>> On 1 August 2013 07:54, Sebastian Messerschmidt
>> <[email protected]> wrote:
>>>
>>> Hello Robert,
>>>
>>> Sorry for catching this so late:
>>> Seems like your re-factoring didn't really produces the correct results.
>>> You can check with the tester2.flt provided earlier and check with the
>>> result image.
>>> I double checked this with OpenFlight creator, and it seems the yaw is
>>> broken.
>>>
>>> With my initial quaternion version is seems correct and if I change the
>>>
>>>
>>> float cos_yaw = cosf(osg::inDegrees(yaw));
>>> float sin_yaw = sinf(osg::inDegrees(yaw));
>>>
>>> to be
>>> float cos_yaw = cosf(osg::inDegrees(-yaw));
>>> float sin_yaw = sinf(osg::inDegrees(-yaw));
>>>
>>> it seems to work as well.
>>> So could you please change this, or do you need the complete diff against
>>> the trunk?
>>
>> Could you send me the whole modified file, this is the most reliable
>> way to make sure that a change is merged as intended and as tested.
>>
>> Cheers,
>> Robert.
>
>
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to