Hi Gui? Xiao? Dao?
Could you sign with you name so we know how to address you. Also for code
submissions I need your name so as I check the submissions in with a name
attribution i,e,
From George Candy, "Fix for all the knowns bugs"
I have looked at your code submission and am not comfortable with multiple
places where there is a check against the UT8 macro that introduces
multiple code paths. I much prefer to avoid this in code as they are an
area that can introduce bugs and increase maintenance load.
My inclination would be to move the check into osgDB::read*File(), although
I haven't thought through all the consequences of this yet. In general
though I'd much rather avoid #ifdef else code proliferating.
Robert.
On 14 August 2013 07:54, HuXiaoDao <[email protected]> wrote:
> (previous mail was in RTF, now send it again in plain text)
>
> command line arguments are always encoded in current system code page, so
> if OSG_USE_UTF8_FILENAME is enabled,
> readNodeFiles can't read any file with non-ansi characters from command
> line, very inconvenient.
>
> so I modified ReadFile.cpp, in this function
>
> Node* osgDB::readNodeFiles(osg::ArgumentParser& arguments,const Options*
> options);
>
> and use convertStringFromCurrentCodePageToUTF8 on every file operation if
> OSG_USE_UTF8_FILENAME is set.
>
> based on svn trunk
>
> _______________________________________________
> osg-submissions mailing list
> [email protected]
>
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
>
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
