Hi Robert,
Looking into it I guess that would be only half a solution. Basically I
don't feel very comfortably with the UserData approach here at all.
I'd rather move it to vertex attributes, as FID, SMC etc. are properties
of triangles rather than geodes...
In general I tend to agree, I'll think of some configurable helper
class, setting up the UserData as configured by the user.
Maybe you can give some advises here, how to make it clean and
maintainable.
cheers
Sebastian
Hi Sebastian,
I have just does a review of the changes and it looks like there is
now a building set of duplicate calls in Geometry.cpp to add the user
data values. With this type of duplication it makes me worried about
bugs being introduced over time as the two code versions diverge.
Might there be an opportunity to move some of the code into the base
class to avoid multiple instances of the same code having to be
maintained? Looking at the classes involved it looks like putting a
helper method into PrimaryRecord to apply the common settings, the
only different looks to be that the Face and Mesh classes would apply
the changes on Geometry and Geode but the object to apply the changes
to could be passed into the help method.
Thoughts?
Robert.
On 31 July 2013 07:23, Sebastian Messerschmidt
<[email protected]
<mailto:[email protected]>> wrote:
Hello Robert,
Attached you'll find a submission regarding some more user data
derived from the OpenFlight features.
Namely this is the Terrain-, Roofline- and Footprint-Flag.
I need this information for instance to apply certain effects only
on special flagged geometry.
I do not feel very comfortable with the way the flags are
transported right now. As they are bits it'd be better to pack
them into a short-value, but exposing the meaning of the bits
doesn't really fit anywhere right now.
Another point which concerns me: how do optimizers handle those
attributes? I guess they don't care, so in worst case if geometry
is reordered or geodes are merged, the flags would simply be wrong
or gone.
cheers
Sebastian
_______________________________________________
osg-submissions mailing list
[email protected]
<mailto:[email protected]>
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
