Hi John, This submission pleased no end :-)
The code looks great, just a couple of small tweaks were required: $ diff LineSegmentIntersector.cpp ~/OpenSceneGraph/src/osgUtil/ 221c221 < Intersector(cf), --- > Intersector(cf, intersectionLimit), 500c500 < double epsilon = 1e-13; --- > double epsilon = 1e-6; I found that the lower epsilon caused problems with axis aligned planar geometries, and the constructor wasn't passing on the intersectionLimit paramater. The second set of changes just as minor: $ diff RayIntersector.cpp ~/OpenSceneGraph/src/osgUtil/ 190,192c190 < // Precision of double is between 15 and 17 significant numerical digits, thus epsilon conservative value < // might be 1e-13 or 1e-14. < const double epsilon = 1e-13; --- > const double epsilon = 1e-6; 322c320 < ++itr) --- > ++itr) Precision again, and a little indentation fix. With this minor tweaks the new RayIntersector is now checked into svn/trunk :-) Many thanks for your patience and efforts. Cheers, Robert. On 27 September 2013 09:09, PCJohn <[email protected]> wrote: > Hi Robert, > > I am attaching a proposal of RayIntersector, implemented according to the > previous discussions on this list. I did not copy-and-paste much of the code > from LineSegmentIntersector. Instead, I tried to "share" the functionality > while making as few API changes as possible. Finally, LineSegmentIntersector > is used for intersections after the ray of RayIntersector is clamped to the > bounding box of a drawable. > > The code was tested by replacing all LineSegmentIntersectors by > RayIntersectors in OSG sources and no problems were noticed. > > Feel free to provide the suggestions for improvements, or made any changes > yourself if you want. > > John > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
