Hi Laurens, Curious that this code hasn't been a problem before, it's been untouched for quite some while - like years. Technically I think the original code is correct, it's legal in C++ to specialize the return type like these two cloneType() were doing. Neither case is improved by the return type being specialized though so have no objection to resetting it to match the parent classes definition. I have merged and checked this code into svn/trunk.
As this code hasn't changed, but the compiler has... a compile bug I'm guessing, do we need to patch the OSG-3.2 branch? Robert. On 10 October 2013 09:47, Laurens Voerman <[email protected]> wrote: > Hi Robert, > attached in zip file are modified versions of: > include/osg/AudioStream > include/osg/**CollectOccludersVisitor > > The (wrong) return type of CollectOccludersVisitor::**cloneType() was > causing problems with Visual Studio. I think it's a bug anyway, but do not > fully grok the linker problems it created (osgviewer.exe exporting the > CollectOccludersVisitor::**cloneType() function). > > The changes to AudioStream are similar, but as it inherits from > osg::Object the defenition of clone and cloneType funcions is not optional. > I expected a compiler warning for the wrong return type, but apparently > it's ignored, so I expect the modified code I send you to compile to the > same result. > > Regards, Laurens. > > > > > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > >
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
