Hi Andreas, Thanks for the changes, code now looks solid and complete, now merges and submitted to svn/trunk. The only tweak I did when merging was to pair the set/get methods so they were alongside it other to ensure the code was in keeping with the way the rest of the OSG is done.
Cheers, Robert. On 9 October 2013 13:25, Andreas Henne <[email protected]> wrote: > Hi Robert, > I changed the code according to your feedback and added the modified > serializer files. I hope that it's enough, otherwise please let me know. > > Kind regards, > Andreas > > > Date: Wed, 2 Oct 2013 11:50:52 +0000 > > From: [email protected] > > To: [email protected] > > Subject: Re: [osg-submissions] Very thin draggers > > > > > Hi Andreas, > > > > I have just reviewed your changes and feel that it'd be best to do a > > bit more work to make sure the changes fit properly with how the rest > > of the OSG works. > > > > One thing I think needs to be added is set/get methods for the various > > visual properties that you want to be user controllable, and osgDB > > serializers provided for these new properties so that if a users > > writes a subgraph with manipulators out to disk and then reloads them > > they will appear the same on screen. > > > > The user of C pointers for storing the objects that we need to modify > > for visual appears is not a good practice and open to dangling > > pointers causing bugs. Using ref_ptr<> is the right way to handle > > keeping persistent references to the objects. > > > > Finally the GL_NORMALIZE mode settings needs to be protected with a > > #fdef guard to prevent it being applied under GLES. > > > > With these changes the additions would be welcome. > > > > Cheers, > > Robert. > > > > > > On 26 September 2013 15:14, Andreas Henne <[email protected]> wrote: > > > Hello, > > > in my application I use the TrackballDragger, the ScaleAxisDragger and > the > > > TranslateAxisDragger. Unfortunately these draggers are very thin and > they do > > > not provide methods to change their visual appearance. Another problem > that > > > I noticed is that lighting on the cones and boxes of the > > > TranslateAxisDragger and ScaleAxisDragger is incorrect when the > draggers are > > > scaled due to not normalized normals. This small patch adresses these > > > problems, providing methods to make the draggers thicker. I have > attached a > > > zip archive containing the corresponding files and also a modified > > > osgManipulator example that makes use of the modifications. I don't > want to > > > retain any copyright. > > > > > > Kind regards, > > > Andreas Henne > > > > > > _______________________________________________ > > > osg-submissions mailing list > > > [email protected] > > > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > > > > _______________________________________________ > > osg-submissions mailing list > > [email protected] > > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > >
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
