Hi Stephan, I have just done an initial review and the specifics seem OK in terms of implementation, however, it doesn't feel quite right in terms of general design - like you it doesn't feel right putting general application settings in window specific class for a single platform.
In osg::GraphicsContext::WindowingSystemInterface there are few set/get methods for screen resolution and refresh rate, perhaps this might be the place to add a new option for setting the menu bar behaviour. Thoughts? Robert. On 8 October 2013 14:56, Stephan Maximilian Huber < [email protected]> wrote: > Hi Robert, > > attached you'll find a new feature for showing / hiding the menubar under > os x. I added a new enum to osg::GraphicsContext::Traits and > osg::DisplaySettings to define the behavior of the os x' menu-bar when > showing fullscreen-windows. It can be set via command-line or env-var > similar to other properties of DisplaySettings / GraphicsContext::Traits. > > To hide the menubar forcefully use --menubar-behavior FORCE_HIDE or > OSG_MENUBAR_BEHAVIOR=FORCE_HIDE > > I am a bit uncomfortable to define an application-wide setting via > GraphicsContext::Traits, but there's currently no other mechanism to do > stuff like this. > > I hope you'll find the submission useful! > > cheers, > > Stephan > > > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > >
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
