HI Mattias, Last year I did a review but felt that I needed to encourage a wider discussion and testing before I merged the changes as I don't know enough about the Windows side to test myself. I was rather busy at the time so didn't raise the topic for discussion as I had plenty of other stuff to get on with. Feel free to strike up a discussion on osg-users. I'm going to be away till Thursday though so won't be able to contribute right away.
Cheers, Robert. On 18 November 2013 13:18, Mattias Helsing <[email protected]> wrote: > Hi Robert, > I noticed this 11 months old submission of mine while clearing my > mail. I'm guessing it got lost in the overflow of submissions you had > on your plate last spring, or you rejected it for some reason. Now I'd > just like to know which it is ;) > > cheers > Mattias > > On Mon, Dec 17, 2012 at 10:33 AM, Mattias Helsing <[email protected]> > wrote: > > Hi Robert, all > > > > I've discovered that OpenThreads::Mutex is reursive on win32 while it is > not > > on linux using pthreads. So I've gone and implemented what > Mutex::MutexType > > suggests. That is - OpenThreads::Mutex is recursive only if you want them > > to. > > > > For normal usage of Mutex nothing changes, but for my (I guess) special > > usage (limit rate) this change makes the Mutex class behave the same on > > linux and win32 > > > > Also - there are code parts in src/OpenThreads/win32/Win32Mutex.cpp that > are > > never used unless you manually uncomment a define in > Win32MutexPrivateData.h > > (USE_CRITICAL_SECTION). I can see from the log (r5443) that these are the > > remnants from a submission by Paul Martz when he switched to using > > EnterCriticalSection instead of the old implementation. This is how I > myself > > implement new functionality - by ifdef'ing it in parallell to the old > code > > (and sometimes it is left that way until my fellow developers questions > my > > sanity and kindly ask me to clean up). That submission got merged in on > > 2006-07-17 = seems to be working ;) I suggest we remove the old code now > and > > that I do it if you think it's appropriate. > > > > cheers > > Mattias > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
