Robert, Just realised that there are two virtual destructors added (apart from the EOF changes). In my it's good, but who am I to tell ;-) All of these changes are in response to errors/warnings at http://cdash.openscenegraph.org/buildSummary.php?buildid=5058
Cheers, Kristofer On 22 November 2013 09:21, Kristofer Tingdahl <[email protected]>wrote: > Robert, > > > following your suggestion, I used the route suggested. Please find the > attached FindRSVG.cmake file. I also did a deeper investigation in the > version number by looking in rsvg's git repository, and I found that the > correct version to use is 2.35, as that is when the missing functions were > introduced. > > I also added a bunch of trivial changes to iron some warnings out. These > warnings are all 'no newline at and of file', so I'm confident I'm not > breaking anything. > > Cheers, > > Kristofer > > > > On 21 November 2013 17:34, Robert Osfield <[email protected]>wrote: > >> Hi Kristofer, >> >> I have just looked into the setting the required minimum version for RSVG >> and while the approach you took viable it isn't quite as clean as playing >> the check into the OSG's FindSVG.cmake via the PKG_CHECK_MODULES line, >> which I've amended to add the required check thus: >> >> PKG_CHECK_MODULES(RSVG librsvg-2.0>=2.16.2) >> >> I'm ready to commit this change but would like to double check the >> version that you've decided upon as the cutoff, you went from any version >> greater than 2.16.1, so for my >= check I went for 2.16.2. However, I >> don't know whether 2.16.2 is appropriate or whether 2.17 or a later version >> might be the appropriate minimum version number. >> >> How did you decided upon this particular version number? >> >> Robert. >> >> >> >> On 21 November 2013 15:52, Kristofer Tingdahl < >> [email protected]> wrote: >> >>> Hi Robert, >>> >>> I tried to build from trunk today on our Centos 5 machiens, and yes, I >>> know that they are ancient, but still. >>> >>> It turns out that the installed RSVG version is too old to be used, >>> which leads to errors, hence I wish to turn it off with this patch >>> to src/osgPluings/CMakeList.txt >>> >>> >>> Cheers, >>> >>> >>> Kristofer >>> >>> -- >>> Kristofer Tingdahl, Ph. D. >>> CEO >>> dGB Earth Sciences >>> >>> _______________________________________________ >>> osg-submissions mailing list >>> [email protected] >>> >>> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >>> >>> >> >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> >> > > > -- > Kristofer Tingdahl, Ph. D. > CEO > dGB Earth Sciences > -- Kristofer Tingdahl, Ph. D. CEO dGB Earth Sciences
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
