Hi Roni, I wasn't able to open the second of the files you attempted to attach, I presume this was the header. I'm afraid the forum isn't reliable when using attachments, the osg-submissions mailing list that it mirrors is far better for submissions as you don't loose files or have them renamed by the forum. The best workaround for the forum attachment problems has historically been to attach the files as a zip file.
While I haven't been able to do a full review as I only have the .cpp file, I have done a graphics diff against the svn/trunk version of GraphicsWindowQt.cpp and understand the approach which is fine. The only thing I was going to change was the naming, I don't see why the member variable should be _retinaScale as the devicePixelRatio() could be present on other devices that have nothing to do with Apple marketing terminology. I believe a better name would be _devicePixelRatio. This is in keeping with what Qt uses and avoids platform specific marketing terms. Cheers, Robert. Robert. On 14 January 2014 11:34, Roni Zanolli <[email protected]> wrote: > Hi Robert, > > I'm sending the fix for the retina display on mac osx and Qt5.2. We have > tested it on Linux/Mac Qt4.8 and Qt5.2 to make sure everything worked fine. > > Cheers, > Roni > > ------------------ > Read this topic online here: > http://forum.openscenegraph.org/viewtopic.php?p=57870#57870 > > > > > Attachments: > http://forum.openscenegraph.org//files/graphicswindowqt_756.cpp > http://forum.openscenegraph.org//files/2099_1389699091._170. > > > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
