Hi Kristofer, The changes look sound and are now merged and submitted to svn/trunk. The only change I made was to rename the applyBBox(..) method to applyBoundingBox(..) to keep it consistent with the OSG convention for full descriptive names for most methods/classes/member variables.
Cheers, Robert. On 20 January 2014 13:27, Kristofer Tingdahl <[email protected]>wrote: > Hi, > > we have a bunch of classes that inherit osg::Node, and they create their > own, internal geometry which is passed into the render bucket at the > cull-traversal. Last week, we realised that these classes are not accounted > for when doing an ComputeBoundVisitor- traversal, as there is no > specialization in ComputeBoundVisitor for them. > > One solution is naturally to create a new class that would inherit the > osg::ComputeBoundVisitor, and use that. I don't like that idea as the > ComputeBoundVisitor does actually have what I need - it is only hidden in a > protected function. > > I am therefor suggesting a slight generalization of the > ComputeBoundVisitor with the attached patch, which is tested. > > The patch has two parts: > > 1. we add applyBBox() so that one can use that in a customized > traverse-function and add a bbox to the visitor. I considered calling this > function expandByBBox(), but I though applyBBox was better. > 2. The MatrixStack is made available to the outside world. That > enables a traverse-function to do whatever it wishes. > > I do actually only need one of the two, as I can implement what I wish > either way, but adding getMatrixStack() will make more generic expansions > possible. > > I wonder if you please could consider this change for the trunk. > > Best regards, > > > Kristofer Tingdahl > > > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > >
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
