Hi Robert, Thanks, changes seem sensible.
Regards, Laurens. On Thu, Jun 26, 2014 at 12:06 PM, Robert Osfield <[email protected]> wrote: > Hi Laurens, > > I have just done a review, I think the correct action would be to > check whether the FileReader has a valid Options object before cloning > and assigning to the reader writer. With the added checks I've > checked in the changes to svn/trunk and OSG-3.2 branch. > > Robert. > > On 25 June 2014 12:28, Voerman, L. <[email protected]> wrote: > > Hi Robert, > > while testing databasepager stuff I noticed that the various loaders > > (osg/ive/osgx) do not pass the current options to the imagePager, > therefore > > the images cannot be found if not in the global OSG_FILE_PATH. Attached > is a > > fix, containing modified versions of > > > > src\osgPlugins\ive\ImageSequence.cpp > > src\osgWrappers\deprecated-dotosg\osg\ImageSequence.cpp > > src\osgWrappers\serializers\osg\ImageSequence.cpp > > > > patch applies both to svn as to branches/OpenSceneGraph-3.2 (files are > > equal). > > > > Regards, Laurens. > > > > _______________________________________________ > > osg-submissions mailing list > > [email protected] > > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
