Okay, if I have time for refactoring, then I'll tell you.

----- Mail original -----
De: "Robert Osfield" <[email protected]>
À: "OpenSceneGraph Submissions" <[email protected]>
Envoyé: Mercredi 17 Décembre 2014 11:06:30
Objet: Re: [osg-submissions] Fix for FBX Writer






Hi Sukender, 

I've merged your changes and submitted it svn/trunk. 

I also began looking at adding a WriteNodeVisitor::apply(osg::Geometry&) method 
but have given up now as was clear quite a few places in the class have 
hardwired to Geode. I don't think this is really required for FBX itself, just 
the approach taken by the original authors of this class. I'm not confident 
enough with FBX and how this class is put together to dive in a refactor it - I 
don't have a collection of FBX files to test against. I also have plenty of 
other things to be getting on with... so if others can jump in a refactor this 
class it'd be much appreciated. 

Cheers, 
Robert. 







On 16 December 2014 at 10:42, Sukender < [email protected] > wrote: 

Hi Robert, 

Here is a fix for the FBX writer: 
" 
FBX writer was writing an empty file when the scene had a root node being a 
Geode. 
This was caused be the change in Drawable (now derived from Node) and Geode 
(now derived from Group). 
This fix simply sticks with previous behaviour. Another change could be to 
adapt WriterNodeVisitor. 
" 

Base revision : SVN trunk 14422 / 381c1b73cdd94ef0f81f77ea3fb1ee4c1ae378d9 

Cheers, 

-- 
Sukender 

_______________________________________________ 
osg-submissions mailing list 
[email protected] 
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org 


_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to