Hi Aurelien,

On 23 October 2013 at 06:47, Robert Osfield <[email protected]>
wrote:

> Hi Aurelien,
>
> I've just done my first pass review and still haven't yet got my head
> fully around it's usage, and in particular whether it's the best way to
> tackle the problem.  Would it be possible for you to write a small OSG
> example that illustrates how you use it?
>
> One thing I'd like to do is make sure that any new DrawBuffer class fits
> in naturally with the rest of FBO usage and doesn't result in confusion and
> misuse by members of the community.
>

I have just returned to reviewing older submissions that weren't closed
originally and have done a second review of your changes. I still feel the
solution likely needs further work, in particular there isn't a coherent
mapping to how osg::Camera is managed.  It sounds like sharing FBO's
between osg::Camera is desired but as this isn't support one ends up
working around it.  I  don't have a concrete example illustrating
osg::DrawBuffers in action so can't comment on the specific usage and how
well it serves the purpose or whether it's existence points to problems
elsewhere in the OSG that really need addressing.

Would it be possible to put together an example?  One could put the
DrawBuffers header and source into a self contained example and then use
this for discussion.

Cheers,
Robert.
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to