I fully agree. IMHO this check may perfectly be removed from the CMake scripts. It doesn't harm however, as you say, virtually everybody will have libswscale. Just a bit of lava code :)
On Thu, Jan 22, 2015 at 10:53 AM, Clément Bœsch <[email protected]> wrote: > On Wed, Jan 21, 2015 at 06:55:24PM +0100, Javier Taibo wrote: > [...] > > Btw, I noticed that, though SWSCALE is supposed to be optional, the > > plug-in code does not compile if it is not present. It crashes because > > "img_convert" is not defined (called from FFmpegDecoderVideo::convert). I > > couldn't find this function in OSG or FFMPEG code. Where is it supposed > to > > be defined? > > > > Anyway, with libswscale present it compiles ok. Now with both ffmpeg > and > > libav. > > > > There is no reason to check for libswscale: it's been included in FFmpeg > since about 4 years (it was originally split out of the repo), a bit > before the Libav fork. See http://ffmpeg.org/archive.html#svn_to_git > > Also note that not using pkg-config to locate the libraries and its > dependency is broken by design and not supported by FFmpeg. The FFmpeg > project, like a large number of other projects, supports the library > linking and its flags through the deployed .pc files (since years). CMake > "finder" should solely rely on this. All these hardcoded paths don't make > much sense and will likely break. (Yes I'm aware pkg-config support in > CMake is really bad). > > [...] > > Best Regards, > > -- > Clément B. > > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > -- Javier Taibo
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
