Hi Mattias, My own fixes are the same as yours and are already checked in.
Thanks, Robert. On 12 March 2015 at 13:42, Mattias Helsing <[email protected]> wrote: > Hi, > yes, disabling will definitely solve the problem ;) > > Otherwise Roberts suggestion works both for android and regular > ubuntu. File attached. > > Mattias > > On Thu, Mar 12, 2015 at 1:47 PM, Jordi Torres <[email protected]> > wrote: > > Hi Mattias and Robert, > > > > I think it does not make sense to have this plugin compiling in Android, > as > > it works as an exporter. So IMO is better to disable it from CMake when > > compiling in Android/iOS. > > Maybe Cedric has something to add and maybe there is interest in > exporting > > from Android/iOS but it is not quite common... > > > > Cheers. > > > > > > 2015-03-12 13:27 GMT+01:00 Robert Osfield <[email protected]>: > >> > >> HI Mattias, > >> > >> I think the simplest approach would be to add a using namespace std; to > >> the top of the file, and then remove the std:: prefixes. This approach > >> would avoid any #ifdef's. > >> > >> Could you try this? > >> > >> I'm currently downloading the Android SDK and NDK to see if I can build > >> the OSG for Android. Rather overdue really :-) > >> > >> Robert. > >> > >> On 12 March 2015 at 10:08, Mattias Helsing <[email protected]> wrote: > >>> > >>> Hi Robert, > >>> The new osgjs plugin fails to build due to usage of std::isfinite and > >>> std::isinf. See: > >>> > >>> > http://cdash.openscenegraph.org/index.php?project=OpenSceneGraph&date=2015-03-12 > >>> > >>> The code is correct; the problem is that stlport (embedded in > >>> android-ndk) doesn't put these functions in the std namespace but in > >>> global one. See this thread: > >>> https://code.google.com/p/android/issues/detail?id=34793 > >>> I'm using android-ndk-r7c and I haven't tested other ndk > >>> > >>> This submission adds some ugle ifdefs to make the android build > >>> succeed. An alternative would be to import std::isfinite and > >>> std::isinf into the global namespace for non-android builds. Do as you > >>> prefer, the submission at least identify the problem. > >>> I also took the liberty to copy the license text from other header to > >>> json_stream > >>> > >>> cheers > >>> Mattias > >>> > >>> _______________________________________________ > >>> osg-submissions mailing list > >>> [email protected] > >>> > >>> > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > >>> > >> > >> > >> _______________________________________________ > >> osg-submissions mailing list > >> [email protected] > >> > >> > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > >> > > > > > > > > -- > > Jordi Torres > > > > > > > > _______________________________________________ > > osg-submissions mailing list > > [email protected] > > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > > > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > >
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
