Hi Laurens,

I'm not comfortable with removing the general purpose DCMTK_LIBRARIES with
a hard-wired version that you have provided.  Elements like :

  IF( WIN32 )
    SET( DCMTK_LIBRARIES ${DCMTK_LIBRARIES} netapi32 )
  ENDIF()

Are missing from your version.

This makes me concerned that the build will break for others even if it
just happens to work for your specific build environment.

Like with the EXR modifications I don't yet know the motivation with
removing the standard DCMTK_LIBRARIES usage, and whether this is the only
solution to handling debug and release builds.

Robert.


On 12 March 2015 at 15:47, Voerman, L. <[email protected]> wrote:

> Hi Robert,
>
> attached is a zip with a modified version of:
> OpenSceneGraph\src\osgPlugins\dicom\CMakeLists.txt
>
> This version links to the debug version of the openEXR libraries,
> useful for better debuggin and to avoid warnings from MSVC.
>
> Also added a /FORCE:MULTIPLE for MSVC to the DCMTK_FOUND version, I don't
> have ITK
> currently availble to test the ITK_FOUND version - leaving that unchanged
> for the moment.
>
> Tested with Visual Studio Express 2013 on 64bit windows 7
>
> This patch applies to both the svn and the 3.2 stable tree.
>
>
> Regards, Laurens Voerman.
>
> _______________________________________________
> osg-submissions mailing list
> [email protected]
>
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
>
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to