Hi Robert, removing ZLIB_LIBRARY was a mistake, zlib is used in openExr. I do add the debug libraries to cmake, but cannot get the debug libraries to be used by the linker unless this modification to the cmake files is made. This seemed to be in line with the other plugins, using TARGET_LIBRARIES_VARS instead of TARGET_EXTERNAL_LIBRARIES. Should I provide a modified FindOpenEXR.cmake as well?
Regards, Laurens. On Thu, Mar 12, 2015 at 6:37 PM, Robert Osfield <[email protected]> wrote: > Hi Laurens, > > Is there a reason why you've taken this approach? I don't yet understand > how this approach provides any different behaviour than just including the > OPENEXR_LIBRARIES as in original CMakeLists.txt. I've looked that the > OSG's FindOpenEXR.cmake and it hasn't got any checks for debug libraries, > are you simply modifying the lib names in CMake? > > Finally what about the ZLIB_LIBRARY reference that appears in the original > CMakeLists.txt but not in your modified line? Is Zlib a redundant > dependency? > > Robert. > > On 12 March 2015 at 15:36, Voerman, L. <[email protected]> wrote: > >> Hi Robert, >> >> attached is a zip with a modified version of: >> OpenSceneGraph\src\osgPlugins\exr\CMakeLists.txt >> >> This version links to the debug version of the openEXR libraries, >> useful for better debuggin and to avoid warnings from MSVC. >> >> Tested with Visual Studio Express 2013 on 64bit windows 7 >> >> This patch applies to both the svn and the 3.2 stable tree. >> >> >> Regards, Laurens Voerman. >> >> >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> >> > > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > >
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
