Hi Jannik, Thanks for the changes. The changes to osgUtil and osgGA I used your changes to prompt me where to make changes, and streamlined the implementations to properly take advantage of the Node/Drawable inheritance. I've removed ShapeToGeometriesVisitor as per your suggestion as it was indeed unused.
The rest of the changes you made to osgconv and the examples all looked sound and are now merged and checked into svn/trunk. On 4 April 2015 at 20:23, Jannik Heller <[email protected]> wrote: > Hi Robert, > > Recently Drawable was changed to inherit from Node instead of Object. I > believe I have discovered some leftovers from before this change. For > example, dynamic_casts to both Drawable* and Node* where casting to Node* > would be sufficient. > > Please note I haven't tested these changes other than checking it > compiles, as I'm not familiar with the changed code not sure where it could > be tested. > > ShapeToGeometriesVisitor seems to be completely unused, so instead of > fixing it we might as well remove it? > > Thanks, > Jannik > > ------------------ > Read this topic online here: > http://forum.openscenegraph.org/viewtopic.php?p=63276#63276 > > > > > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > >
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
