Tim Moore writes: > The first use of remove() in LRUCache::addEntries() must not be > wrapped with erase(). The removed entries are overwritten with new > entries. > > The patch concerns the remove() in > VertexCacheVisitor::doVertexOptimization. erase() isn't appropriate > here either: the code is in a tight loop, and the whole vector is > deleted at the end of the function anyway. However, I'm not convinced > that the remove() is doing anything useful and will ponder that.
Thanks for the heads-up, Tim. However, I think that this should be eventually commented in the code, since it resembles to a common mistake when one reads the code. If no one beats me to it, I will make a submission with those explanations in your mail. Regards, -- Alberto _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
