Hi Jannik. I tackled other submissions first as they were more critical or beneficial. A tiny, almost negligible performance tweak like this is something that I is only really warranted for inner loops. The changes don't carry a significant risk of introducing a bug so I've have merged and checked in the changes, minus the change to using std::sqrt.
I agree that std:sqrt is technically the best solution for this particular code, but I'm not confident that all compilers that the OSG get used with properly support it. Yes this is really stupid but we've had problems like this in the past. Robert. On 7 May 2015 at 18:31, Jannik Heller <[email protected]> wrote: > Actually, sqrt is incorrect too. Instead std::sqrt should be used, the c++ > function, that is overloaded with (double) and (float) variants. The compiler > will pick the correct function overload depending on the precision that the > OSG is configured with. > > I also rebased the patch against svn/trunk r14865. > > ------------------ > Read this topic online here: > http://forum.openscenegraph.org/viewtopic.php?p=63659#63659 > > > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
