Hi Remi, I have just done a quick review of your changes and feel that it would be more useful if there was two separate techniques implemented - and old fixed function approach and a new shader based one. On GLES2+GL3+ one would not implement the fixed function one and just have the shader one, while on other GL variations one would be able to select either at runtime.
Thoughts? Robert. On 2 July 2015 at 13:02, Thebault, Remi <[email protected]> wrote: > Hello > > osgFX::Outline does not work in GL3 mode > I get the following warnings, and no outline rendered > > Warning: PolygonMode::apply(State&) - only GL_FRONT_AND_BACK is supported. > > Warning: Material::apply(State&) - not supported. > > Attached is a simple fix. > I changed the line polygon mode from GL_BACK to GL_FRONT_AND_BACK. > I introduced a minimal shader program with material color uniform. > > I surrounded changes with OSG_GL3_AVAILABLE preprocessor tests > > now rendering works, and I don't get the warnings anymore. > > please review > > Cheers, > Rémi > > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > >
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
