Hi KOS, I have done a trial merge of your proposed changes to FindGStreamer.cmake and it works on my Kubuntu 14.04 system with gstreamer-1.4.5 installed - gstreamer is found and the gstreamer plugin compiles and links without any errors.
However, there is a difference in behaviour that makes me hesitant to merge right away. The old code goes through the extra step of using pkg_check_modules on a PC_ prefixed names, then uses these to use Cmake standard find_path and find_library to set up the actual final cmake variables that the plugin uses. The only reason I can spot for this odd extra step is the CMake standard find_ approach places the set up variables in scale that ccmake can edit, while the pkg_check_modules variables are hidden as they are set to INTERNAL. I presume making the variables visiable and editable in ccmake allows users a an easy way to double check paths and edit where appropriate. Did you found out why the original code was failing in your case? Robert. On 17 July 2015 at 15:50, Konstantin <[email protected]> wrote: > Hello, Robert. > > I've mentioned in the "osg-users" ML about build error with the newest > GStreamer 1.5 > > Please, have a look at the attached patch. > > CMakeModules/FindGStreamer.cmake > > > KOS > > > > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > >
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
