Hi Andy, Thanks for the explanation. I've tested out the changes on my Kubuntu system and everything looks to be working fine. I have merged and checked into svn/trunk and OSG-3.4 branch.
Robert. On 3 August 2015 at 13:33, Andy Skinner <[email protected]> wrote: > Thanks, Robert. > > > > Yes, we compile on a system with SGIX defined. Someone was trying to run > in optirun, with which I'm not really familiar, but its GLX didn't have > SGIX. > > > > Unfortunately, there are a lot of levels of indirection here for testing. > My own group doesn't even use osgViewer, but another group in my company > does, and so the library is linked in. I don't know if either of us need > to actually support pbuffers, but it is the presence of the symbols that is > the problem. We don't even yet know if this customer's system will have > other problems, but are trying to check that. > > > > It is the coming stable release that made us want to try this. Thanks for > your consideration. We have been needing an upgrade for a while. > > > > thanks > > andy > > > > *From:* osg-submissions [mailto: > [email protected]] *On Behalf Of *Robert > Osfield > *Sent:* Monday, August 03, 2015 7:06 AM > *To:* OpenSceneGraph Submissions <[email protected] > > > *Subject:* Re: [osg-submissions] Avoid use of older symbol in > osgViewer.cpp > > > > Hi Andy, > > I have merged the changes and tested them and Pbuffer creation still works > fine on my Kubuntu 15.04 + NVidia system. I am curious about the > compilation and delivery of the OSG for your customer. My guess is that on > your system you had the SGIX extensions listed in the header but the final > GLX implementation on the client computer didn't have the symbols. > > Robert. > > > > On 3 August 2015 at 09:08, Robert Osfield <[email protected]> > wrote: > > Hi Andy, > > I have just done a quick pass through the changes. I'm a bit nervous > about making changes this close to a stable release, so we have to make > sure we get them right if we are to apply them. > > What system system had problems? Do they need PBuffers to work? > > Have you tested pbuffers still working? > > > > Robert. > > > > > > On 31 July 2015 at 21:40, Andy Skinner <[email protected]> wrote: > > Someone was using our code on a system that does not seem to have the SGIX > symbols used in osgViewer.cpp. > > > > I used osgSetGLExtensionsFuncPtr to remove the symbols. I don't know how > to test this path, but it did remove the symbols from libosgViewer.so. I > have also not been able yet to see if that was sufficient for our customer. > > > > I did this by looking at other cases, and I tried to follow some of the > same practices in PixelBufferX11, like using _useSGIX in a similar way to > the previous _*useGLX1*_3. > > > > I don't know whether this is the right thing, or whether it would be fine > to remove this code and replace with more modern. > > > > Advice appreciated. > > > > I originally made these changes in an older version, but these files were > based off of the trunk from the SVN repository. > > > > thanks > > andy > > > > > > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > > > > > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > >
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
