HI Julian,
I have reviewed your changes but feel that a full bitmask implementation
would be more appropriate as this would allow for access via scripting and
make the ascii format human readable. I also add a version check to keep
the serializer backwards compatible, the code I went with is:
{
UPDATE_TO_VERSION_SCOPED( 140 )
BEGIN_INT_BITFLAGS_SERIALIZER( ImplicitBufferAttachmentRenderMask,
osg::Camera::USE_DISPLAY_SETTINGS_MASK );
ADD_BITFLAG_VALUE( IMPLICIT_DEPTH_BUFFER_ATTACHMENT,
osg::Camera::IMPLICIT_DEPTH_BUFFER_ATTACHMENT );
ADD_BITFLAG_VALUE( IMPLICIT_STENCIL_BUFFER_ATTACHMENT,
osg::Camera::IMPLICIT_STENCIL_BUFFER_ATTACHMENT );
ADD_BITFLAG_VALUE( IMPLICIT_COLOR_BUFFER_ATTACHMENT,
osg::Camera::IMPLICIT_COLOR_BUFFER_ATTACHMENT );
ADD_BITFLAG_VALUE( USE_DISPLAY_SETTINGS_MASK,
osg::Camera::USE_DISPLAY_SETTINGS_MASK );
END_BITFLAGS_SERIALIZER();
BEGIN_INT_BITFLAGS_SERIALIZER( ImplicitBufferAttachmentResolveMask,
osg::Camera::USE_DISPLAY_SETTINGS_MASK );
ADD_BITFLAG_VALUE( IMPLICIT_DEPTH_BUFFER_ATTACHMENT,
osg::Camera::IMPLICIT_DEPTH_BUFFER_ATTACHMENT );
ADD_BITFLAG_VALUE( IMPLICIT_STENCIL_BUFFER_ATTACHMENT,
osg::Camera::IMPLICIT_STENCIL_BUFFER_ATTACHMENT );
ADD_BITFLAG_VALUE( IMPLICIT_COLOR_BUFFER_ATTACHMENT,
osg::Camera::IMPLICIT_COLOR_BUFFER_ATTACHMENT );
ADD_BITFLAG_VALUE( USE_DISPLAY_SETTINGS_MASK,
osg::Camera::USE_DISPLAY_SETTINGS_MASK );
END_BITFLAGS_SERIALIZER();
}
Could you please update to OSG svn/trunk and test.
Thanks,
Robert
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
