Hi Mathias, Thanks for the changes. I have merged them with svn/trunk and OSG-3.4 branch.
When I reviewed the changes it struck me the best solution would actually be to move all the resize handling code into dedicated method that gets invoked with the ConfigureNotify and MapNotify events. This dedicated method would handle all the internal work like calling XTranslateCoordinates and dispatching the osgGA event for the resize. However, while this approach would keep the code clean it would also change the API so I've gone with your solution. Robert On 4 November 2015 at 17:40, Mathias Fröhlich <[email protected]> wrote: > > > Hi Robert, > > > > as promised here a change to avoid unconditional per frame round > > trips to the X server. > > > > The change is based on rev 15172 and taken from trunk. > > The patch itself applies fine on the latest release branch. > > > > There is where I have been running this change now for some > > short amount of time. > > But before that I had been running something even more restrictive > > just backing out the XGetWindowAttributes/XTranslateCoordinates > > pair completely - which worked fine in my environment. > > That said my testing is probably not representative. > > > > Anyway, the window geometry query and translation is now restricted to > > a ConfigureNotify or a MapNotify event which seems plausible to me > > to potentially get a new window geometry. > > > > Please review/apply > > > > Thanks > > > > Mathias > > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > >
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
