Hi Laurens, I have done a first pass review but as there are quite a few changes and how best to tackle integrating the dxtc functionality/providing a graceful fallback in case of lack of crucial decoding code hasn't yet been resolved I feel I need some more time to let the issue sink in. I will came back to it in the near future to decide how best to proceed.
Cheers, Robert. On 27 May 2016 at 12:29, Voerman, L. <[email protected]> wrote: > Hi Robert, > Here is a version with the offending code left out, all offending parts > would be in the dxtctool.cpp file. > > The full version of this file - including the implementation of the decode > funcions - is attached as dxtctool_FULL.cpp. I'm not very skilled with > github, but I can try to make a patch from this - I suppose that would make > it available to the osg users as an option? > > Changed files are updated to current git head. (= include minor change in > the ImageUtils.cpp) > Regards, Laurens. > > On Thu, May 26, 2016 at 6:00 PM, Robert Osfield <[email protected]> > wrote: >> >> Hi Laurens, >> >> Just working my way through submissions. The patent mess with S3TC >> are a show blocker until the patent expires or there is public >> declaration from those marshalling S3RTC that the code does not >> infringe. >> >> If there are parts of the submission that won't infringe could you >> separate them out? Perhaps you could clone the OSG repostory on >> github and then create a patch with the changes without the code that >> is likely to be in the clear and on with code that would need to >> checked against the scope of the patent? >> >> Cheers, >> Robert. >> >> On 17 March 2016 at 12:31, Voerman, L. <[email protected]> wrote: >> > Hi Jannik, >> > >> > thanks for your question, basically I have no idea what the answer >> > should >> > be. The rotate block and retrieve value functions do interpret the >> > content >> > of the compressed blocks, and therefore might be prohibited. >> > Any advise on the legality would be appreciated, as I cannot fully >> > understand a patent covering the possibility to decode an image. >> > Even though I wrote the code based on publicy available descriptions of >> > the >> > format, I forgot that the format itself could be patented. >> > I do not intend to expose all osg users to patent fee claims - so the >> > implementation might need to be disabled until the patent expires, the >> > page >> > you link says: Estimated expiry: Oct 2, 2017 >> > >> > Regards, Laurens. >> > >> > ps. >> > 1> I suppose copying compressed blocks alligned to it's footprint should >> > be >> > fine, as the content of the block is not interpreted and the idea of >> > grouping compressed pixels in blocks is not patented. >> > >> > 2> would an conditional compile like >> > #ifdef THIS_PATENT_HAS_EXPIRED >> > be sufficient to protect the osg community against claims? >> > the most convenient place to store the code for me is still in the >> > osg >> > repository, and it might be usefull to describe the reason for not >> > compiling >> > it into the osg. >> > >> > >> > >> > On Thu, Mar 17, 2016 at 11:58 AM, Jannik Heller <[email protected]> >> > wrote: >> >> >> >> Hi Laurens, >> >> >> >> Great changes, sounds like very useful features. Though, perhaps the >> >> addition to "get pixels from dxtc compressed textures", if it is what I >> >> think it is, should wait until the S3TC patent expires? >> >> http://www.patentcountdown.org/ >> >> >> >> ------------------ >> >> Read this topic online here: >> >> http://forum.openscenegraph.org/viewtopic.php?p=66554#66554 >> >> >> >> >> >> >> >> >> >> >> >> _______________________________________________ >> >> osg-submissions mailing list >> >> [email protected] >> >> >> >> >> >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> > >> > >> > >> > _______________________________________________ >> > osg-submissions mailing list >> > [email protected] >> > >> > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> > >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
